Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): allow other data types for span data values #784

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Feb 16, 2024

Closes #758

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1e97da) 80.95% compared to head (1be7893) 80.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   80.95%   80.89%   -0.06%     
==========================================
  Files          48       48              
  Lines        4714     4717       +3     
==========================================
  Hits         3816     3816              
- Misses        761      763       +2     
- Partials      137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit 255c172 into getsentry:master Feb 16, 2024
20 checks passed
@aldy505 aldy505 deleted the fix/otel-attribute-casting branch February 17, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTel SDK casts all span data values to string
2 participants