-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to skip frames #852
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
==========================================
- Coverage 82.09% 82.05% -0.04%
==========================================
Files 51 51
Lines 4518 4520 +2
==========================================
Hits 3709 3709
- Misses 661 662 +1
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
I fear this is something we would need to expose on the top level methods too :/ |
I've added it to CaptureMessage, CaptureEvent, Recover/RecoverWithContext. |
This reverts commit d95747f. # Conflicts: # CHANGELOG.md # stacktrace.go
I don't find this solution elegant in particular, but it adds ability to skipFrames in StackTrace (which resolves #741 for example).
Is EventFromMessage invoked directly by external users? If so, this would be a breaking change and instead a variadic options/parameter could be added.
I'll add tests once we agree on the implementation.