Fix: Sentry Timber integration does not submit msg.formatted breadcru…

…mbs (#1957)
getsentry · Mar 23, 2022 · 060811b · 060811b
1 parent d102908
commit 060811b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+* Fix: Sentry Timber integration does not submit msg.formatted breadcrumbs (#)
+
 ## 5.7.0
 
 * Feat: Automatically enable `Timber` and `Fragment` integrations if they are present on the classpath (#1936)

diff --git a/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt b/sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
@@ -252,7 +252,7 @@ class SentryTimberTree(
                 msg.message != null -> Breadcrumb().apply {
                     level = sentryLevel
                     category = "Timber"
-                    message = msg.message
+                    message = msg.formatted ?: msg.message
                 }
                 throwableMsg != null -> Breadcrumb.error(throwableMsg).apply {
                     category = "exception"

diff --git a/sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt b/sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt
@@ -215,6 +215,18 @@ class SentryTimberTreeTest {
         )
     }
 
+    @Test
+    fun `Tree adds a breadcrumb with formatted message and arguments, when provided`() {
+        val sut = fixture.getSut()
+        sut.e("test count: %d", 32)
+
+        verify(fixture.hub).addBreadcrumb(
+                check<Breadcrumb> {
+                    assertEquals("test count: 32", it.message)
+                }
+        )
+    }
+
     @Test
     fun `Tree adds a breadcrumb if min level is equal`() {
         val sut = fixture.getSut()