Skip to content

Commit

Permalink
Do not set tags.
Browse files Browse the repository at this point in the history
  • Loading branch information
maciejwalkowiak committed Sep 15, 2021
1 parent 1c34fa1 commit dca2176
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class SentryApolloInterceptor(
// we have no access to URI, no way to verify tracing origins
val headers = request.requestHeaders.toBuilder().addHeader(sentryTraceHeader.name, sentryTraceHeader.value).build()
val requestWithHeader = request.toBuilder().requestHeaders(headers).build()
span.setTag("operationId", requestWithHeader.operation.operationId())
span.setTag("variables", requestWithHeader.operation.variables().valueMap().toString())

chain.proceedAsync(requestWithHeader, dispatcher, object : CallBack {
override fun onResponse(response: InterceptorResponse) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ class SentryApolloInterceptorTest {
val httpClientSpan = it.spans.first()
assertEquals("LaunchDetails", httpClientSpan.op)
assertEquals("query LaunchDetails", httpClientSpan.description)
assertNotNull(httpClientSpan.tags["operationId"])
assertEquals("{id=83}", httpClientSpan.tags["variables"])
}

private fun executeQuery(sut: ApolloClient = fixture.getSut(), isSpanActive: Boolean = true) = runBlocking {
Expand Down

0 comments on commit dca2176

Please sign in to comment.