Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttp callback for Customising the Span #1365

Closed
marandaneto opened this issue Mar 30, 2021 · 0 comments · Fixed by #1478
Closed

OkHttp callback for Customising the Span #1365

marandaneto opened this issue Mar 30, 2021 · 0 comments · Fixed by #1478
Labels
enhancement New feature or request OkHttp performance Performance API issues

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Mar 30, 2021 •
edited
Loading

Lets add a callback to the OkHttp integration (ctor param?) that allows the user to customize the Span, there's no way to do it right now.

https://github.com/getsentry/sentry-java/blob/main/sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt#L11

Related to #1362
@marandaneto marandaneto added enhancement New feature or request performance Performance API issues OkHttp labels Mar 30, 2021
maciejwalkowiak added a commit that referenced this issue May 17, 2021
@maciejwalkowiak
Feat: OkHttp callback for Customising the Span
0a24fae 
Fixes #1365
@maciejwalkowiak maciejwalkowiak mentioned this issue May 17, 2021
Merged
4 tasks
maciejwalkowiak added a commit that referenced this issue May 19, 2021
@maciejwalkowiak
Merge branch 'main' into gh-1365
73ad945
maciejwalkowiak added a commit that referenced this issue May 24, 2021
@maciejwalkowiak
Merge branch 'main' into gh-1365
6c95fbe
maciejwalkowiak added a commit that referenced this issue May 25, 2021
@maciejwalkowiak
Feat: OkHttp callback for Customising the Span (#1478)
5b6d1ea 
Fixes #1365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request OkHttp performance Performance API issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: OkHttp callback for Customising the Span getsentry/sentry-java
1 participant
@marandaneto