Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry NDK integration is compiled against default NDK and CMake versions based on AGP's version #1048

Merged
merged 11 commits into from
Nov 16, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 16, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Sentry NDK integration is compiled against default NDK and CMake versions based on AGP's version

💡 Motivation and Context

AGP version is heavily tested against a specific NDK version, and usually not the latest, we'd like to do the same so we don't run into unknown problems.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title Sentry NDK integration is compiled against default NDK version based on AGP's version Sentry NDK integration is compiled against default NDK and CMake versions based on AGP's version Nov 16, 2020
@marandaneto
Copy link
Contributor Author

@Swatinem JFI
https://developer.android.com/studio/projects/install-ndk#apply-specific-version
currently AGP 4.1.1 = NDK 21.1 instead of 21.3
CMake 3.10

.appveyor.yml Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #1048 (25f2dfd) into main (ae8c568) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1048   +/-   ##
=========================================
  Coverage     72.06%   72.06%           
  Complexity     1338     1338           
=========================================
  Files           138      138           
  Lines          4893     4893           
  Branches        499      499           
=========================================
  Hits           3526     3526           
  Misses         1106     1106           
  Partials        261      261           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8c568...f820503. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good catch! We should definitely stay in sync in terms of NDK version

@marandaneto marandaneto merged commit f98e258 into main Nov 16, 2020
@marandaneto marandaneto deleted the enha/default-ndk-version branch November 16, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants