-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry NDK integration is compiled against default NDK and CMake versions based on AGP's version #1048
Conversation
@Swatinem JFI |
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
=========================================
Coverage 72.06% 72.06%
Complexity 1338 1338
=========================================
Files 138 138
Lines 4893 4893
Branches 499 499
=========================================
Hits 3526 3526
Misses 1106 1106
Partials 261 261 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good catch! We should definitely stay in sync in terms of NDK version
📢 Type of change
📜 Description
Sentry NDK integration is compiled against default NDK and CMake versions based on AGP's version
💡 Motivation and Context
AGP version is heavily tested against a specific NDK version, and usually not the latest, we'd like to do the same so we don't run into unknown problems.
💚 How did you test it?
📝 Checklist
🔮 Next steps