feat: Add basic support for attachments #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope.clear is not covered by tests. This is fixed now by adding a test for it.
bruno-garcia
reviewed
Dec 1, 2020
philipphofmann
requested review from
maciejwalkowiak and
marandaneto
as code owners
marandaneto
reviewed
Dec 2, 2020
sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/MainActivity.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Dec 2, 2020
sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/MainActivity.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 2, 2020
marandaneto
reviewed
Dec 7, 2020
| * @throws IOException an IOException | ||
| */ | ||
| @Override | ||
| public void serialize(final @NotNull SentryEnvelope envelope, final @NotNull Writer writer) | ||
| throws Exception { | ||
| public void serialize(SentryEnvelope envelope, OutputStream stream) throws Exception { |
There was a problem hiding this comment.
Suggested change
| public void serialize(SentryEnvelope envelope, OutputStream stream) throws Exception { | |
| public void serialize(final @NotNull SentryEnvelope envelope, final @NotNull OutputStream stream) throws Exception { |
M: double-check if there are more missing.
There was a problem hiding this comment.
H: not sure if it's possible to use, as the OutputStream comes from the connection, but BufferedOutputStream exists
There was a problem hiding this comment.
H: I'd rename to outputStream as inputStream also exists.
marandaneto
reviewed
Dec 7, 2020
| writer.write(buffer, 0, charsRead); | ||
| } | ||
| } | ||
| for (SentryEnvelopeItem item : envelope.getItems()) { |
There was a problem hiding this comment.
Suggested change
| for (SentryEnvelopeItem item : envelope.getItems()) { | |
| for (final SentryEnvelopeItem item : envelope.getItems()) { |
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
…nto feat/attachments
bruno-garcia
reviewed
Dec 7, 2020
| */ | ||
| @NotNull | ||
| List<Attachment> getAttachments() { | ||
| return attachments; |
There was a problem hiding this comment.
Here we need to return a new instance of a list instead of our private one
bruno-garcia
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add basic support for attachments.
💡 Motivation and Context
💚 How did you test it?
Unit tests and with a sample project.
📝 Checklist
🔮 Next steps