Bump AGP to 7.0.2 #1650
Merged
Bump AGP to 7.0.2 #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Aug 17, 2021
|
@maciejwalkowiak can you confirm that compiling the Java projects with Java 11 but target/source being Java 8 won't cause any harm? since the new Android Gradle Plugin requires Java 11, either we split up in 2 Gradle projects or we use Java 11 targeting Java 8 |
|
spotless hits the issue diffplug/spotless#834 if using Java 16 |
marandaneto
commented
Sep 14, 2021
| @@ -19,7 +19,7 @@ jobs: | |||
| # TODO: windows-latest | |||
| os: [ubuntu-latest, macos-latest] | |||
| # Zulu Community distribution of OpenJDK | |||
| java: [ '8', '11' ] | |||
| java: [ '11' ] | |||
There was a problem hiding this comment.
didn't remove the matrix because we want to add Java 16 later
|
"target" means the latest Java version runtime we want to support. I don't see any way it can cause any harm. |
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
romtsn
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Bump AGP to 7.0.2
💡 Motivation and Context
Closes #1646
💚 How did you test it?
CI/running
📝 Checklist
🔮 Next steps