Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug log serializable objects #1795

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Debug log serializable objects #1795

merged 3 commits into from
Nov 8, 2021

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Nov 4, 2021 •
edited
Loading

📜 Description

  • Log serialisable objects (with pretty printing)
  • Serialize any object, not just JsonSerializable

Closes #1792

💡 Motivation and Context

This functionality was lost when replacing GSON.

💚 How did you test it?

  • Checked wether serialized object was logged correctly.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase changed the base branch from main to 6.x.x November 4, 2021 16:29
@denrase denrase self-assigned this Nov 4, 2021
@denrase denrase marked this pull request as ready for review November 4, 2021 16:40
marandaneto
marandaneto approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing changelog, LGTM

@marandaneto marandaneto merged commit ba1d4c2 into 6.x.x Nov 8, 2021
@marandaneto marandaneto deleted the feat/debug-log-serializable-objects branch November 8, 2021 08:47
@bruno-garcia bruno-garcia mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

@romtsn romtsn Awaiting requested review from romtsn

Assignees

@denrase denrase

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print serialised envelopes to the console in debug mode.
2 participants
@denrase @marandaneto