Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not create SentryExceptionResolver bean when Spring MVC is not on the classpath #1865

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Fix: Do not create SentryExceptionResolver bean when Spring MVC is not on the classpath #1865

merged 2 commits into from
Jan 11, 2022

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Do not create SentryExceptionResolver bean when Spring MVC is not on the classpath

💡 Motivation and Context

Fixes #1863

💚 How did you test it?

Integration test.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review January 6, 2022 11:46
@bruno-garcia bruno-garcia merged commit 72b2344 into main Jan 11, 2022
@bruno-garcia bruno-garcia deleted the gh-1863 branch January 11, 2022 23:37
@bruno-garcia
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@marandaneto marandaneto marandaneto approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.ClassNotFoundException: org.springframework.web.servlet.HandlerExceptionResolver
3 participants
@maciejwalkowiak @bruno-garcia @marandaneto