-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Spring Boot to 2.3.4. #932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
=========================================
Coverage 70.66% 70.66%
Complexity 1206 1206
=========================================
Files 122 122
Lines 4465 4465
Branches 454 454
=========================================
Hits 3155 3155
Misses 1063 1063
Partials 247 247 Continue to review full report at Codecov.
|
Just a reminder to generally target the lowest possible version here. |
This is the latest version: https://search.maven.org/artifact/org.springframework.boot/spring-boot-starter Do we want to go this direction? What woud be the lowest version we can target our lib that it would still compile/work? |
We possibly need two versions here: One of the sample which can be this one (latest) |
I am not sure how does it work, but when projects use But, to make sure that it does work with the range of versions it would be nice if we could test against all of them. Not sure how to do it though. |
I find that an odd dependency resolution strategy. How do they make sure things are compatible? In general libraries target the lowest version they need. The app has that as a base requirement for compatibility with the framework. |
📢 Type of change
📜 Description
Upgrade Spring Boot to 2.3.4.
📝 Checklist