Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solidstart e2e test app #12547

Closed
Tracked by #12538
andreiborza opened this issue Jun 19, 2024 · 0 comments · Fixed by #12873
Closed
Tracked by #12538

Add solidstart e2e test app #12547

andreiborza opened this issue Jun 19, 2024 · 0 comments · Fixed by #12873
Assignees
@andreiborza
Labels
Package: solidstart Issues related to the Sentry SolidStart SDK

Comments

@andreiborza
Copy link
Member

No description provided.

@andreiborza andreiborza mentioned this issue Jun 19, 2024
Open
@andreiborza andreiborza self-assigned this Jun 19, 2024
@andreiborza andreiborza added the Package: solidstart Issues related to the Sentry SolidStart SDK label Jun 19, 2024
@andreiborza andreiborza changed the title Add e2e test app Add solidstart e2e test app Jun 19, 2024
@andreiborza andreiborza mentioned this issue Jul 11, 2024
Merged
andreiborza added a commit that referenced this issue Jul 11, 2024
@andreiborza
test(solidstart): Add solidstart e2e test app (#12873)
4852dc7 
For now this only tests client side errors. It also doesn't use the
solidrouter integration yet because it fails to resolve the
`@sentry/solidstart/solidrouter` import properly in our repo. I have yet
to figure out what exactly is causing this (my guess is some pnpm
shenanigans). I couldn't reproduce this in a sample app outside of our
repo yet.

Closes: #12547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreiborza andreiborza

Labels
Package: solidstart Issues related to the Sentry SolidStart SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(solidstart): Add solidstart e2e test app getsentry/sentry-javascript
1 participant
@andreiborza