Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record spans dropped via beforeSendTransaction #12849

Closed
mydea opened this issue Jul 10, 2024 · 0 comments · Fixed by #13022
Closed

Record spans dropped via beforeSendTransaction #12849

mydea opened this issue Jul 10, 2024 · 0 comments · Fixed by #13022
Assignees
@mydea

Comments

@mydea
Copy link
Member

mydea commented Jul 10, 2024 •
edited by cleptric
Loading

Follow up to #12727, and part of getsentry/team-sdks#88, we should also record spans dropped in beforeSendTransaction, event processors, hooks, etc. as client reports.
@mydea mydea self-assigned this Jul 23, 2024
@mydea mydea mentioned this issue Jul 23, 2024
Merged
@mydea mydea closed this as completed in df45d65 Jul 29, 2024
krystofwoldrich pushed a commit that referenced this issue Aug 13, 2024
@mydea @krystofwoldrich
feat(core): Capture # of dropped spans through beforeSendTransaction (
305f4f4 
#13022)

Fixes #12849.

This is a bit tricky because `beforeSendTransaction` can return a
promise, so in order to avoid dealing with this I put the # of spans on
the sdk metadata, and then compare that afterwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): Capture # of dropped spans through beforeSendTransaction getsentry/sentry-javascript
1 participant
@mydea