feat(solidstart): Add solidstart SDK basic package #12730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
added
the
Package: solidstart
andreiborza
force-pushed
the
ab/solidstart-package
branch
from
69b1bb2
to
a6a1fe3
Compare
mydea
approved these changes
Jul 2, 2024
| @@ -78,7 +78,7 @@ | |||
| "build:transpile:watch": "rollup -c rollup.npm.config.mjs --watch", | |||
| "build:types:watch": "tsc -p tsconfig.types.json --watch", | |||
| "build:tarball": "npm pack", | |||
| "circularDepCheck": "madge --circular src/index.ts", | |||
| "circularDepCheck": "madge --circular src/index.ts && madge --circular src/solidrouter.ts", | |||
Comment on lines
+21
to
+27
| export declare const getClient: typeof clientSdk.getClient; | ||
|
|
||
| export declare function close(timeout?: number | undefined): PromiseLike<boolean>; | ||
| export declare function flush(timeout?: number | undefined): PromiseLike<boolean>; | ||
| export declare function lastEventId(): string | undefined; | ||
|
|
||
| export declare const continueTrace: typeof clientSdk.continueTrace; |
There was a problem hiding this comment.
do all of these still differ, actually? (put differently, does it not work without these being defined?
AbhiPrasad
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12545, #12546