ci: Update size-limit to ensure bundle size optimization #13571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/fix-size-limit-terser
branch
from
b2a0787
to
0ae12f5
Compare
Lms24
approved these changes
Sep 4, 2024
lforst
added a commit
that referenced
this pull request
Sep 30, 2024
The peer dependency introduced in #13571 seems to be too strict. After installing the latest next version (14.2.13) and @sentry/next version (8.32.0), I get the following: ```sh └─┬ @sentry/nextjs 8.32.0 └── ✕ unmet peer webpack@5.94.0: found 5.95.0 ``` --------- Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add a new entry for size limit with sentry browser with max. tree shaking. While doing this, I noticed that bundle size did not shrink as much as I would have expected it. After playing around some, I noticed that it was not actually shaking out the constant changes, for whatever reason. Probably some size-limit internal default config.
Now, i actually add terser to ensure it fully minimizes & tree shakes stuff for us.