Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Update CHANGELOG for 8.30.0 #13648

Merged
merged 24 commits into from
Sep 10, 2024
Merged

meta: Update CHANGELOG for 8.30.0 #13648

merged 24 commits into from
Sep 10, 2024

Conversation

AbhiPrasad
Copy link
Member

resolves #13646

Getting a new release out so we can fix some of the peer dep issues with installing the SDK.

andreiborza and others added 21 commits September 9, 2024 09:05
meta(changelog): Update changelog for 8.29.0
…cing (#13485)

This PR migrates the `nativeNodeFetchIntegration` to use
`@opentelemetry/instrumentation-undici` instead of
`opentelemetry-instrumentation-fetch-node`.

The instrumentation is still exported as `nativeNodeFetchIntegration`
and is named `NodeFetch` to ensure backwards compatibility and the tests
pass ~~without changes~~.

Note: One `nextjs-14` e2e test did need a change due to the
new/differing attribute names.

It's worth noting that `@opentelemetry/instrumentation-undici` [uses
different
attributes](open-telemetry/opentelemetry-js-contrib#2417 (comment))
from the latest semantic convention version vs what we are using and
what's used by `opentelemetry-instrumentation-fetch-node`. It looks like
the [http instrumentation is migrating to these
too](open-telemetry/opentelemetry-js#4940) so
some of the changes in this PR will ensure that the http instrumentation
continues to work after these updates.
…r without `<>` (#13543)

Ensure that the component names listed in the `trackComponent` option match regardless of if they were specified as `<Name>` or `Name`. Add unit and e2e tests for component tracking. 

---------

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13543

Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Changes the rate-limiting tests to use fake timers. This takes the test
time from 24s to 4s.
[Gitflow] Merge master into develop
> This is a draft PR as this approach leads to an error as `hook.mjs` is
not included in the `node_modules`. This has been fixed upstream but was
not yet released for nuxt.

Makes it possible to include a `sentry.server.config.ts` file in the
root folder alongside `sentry.client.config.ts`. Currently, it has to be
added in the `public` folder which is not 100% ideal.
While working on updating [`sentry-javascript-bundler-plugins` to use v8
of the JavaScript
SDK](getsentry/sentry-javascript-bundler-plugins#579),
I found that I was unable to set measurements as the global client is
not used.

If you're not using a global client, there is currently no way to add
measurements because `Sentry.setMeasurement()` relies on
`getActiveSpan()` which in turn relies on `getCurrentScope()`.

This PR moves the `activeSpan` into the last parameter which defaults to
`getActiveSpan()`.
…13541)

`PerformanceObserver` is available on iOS 11 and later, but
the `supportedEntryTypes` method is available on iOS 13 and later.

ref:
https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver

Therefore, a runtime error will occur if we use Sentry on iOS 11 or iOS
12.
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13541

Co-authored-by: AbhiPrasad <18689448+AbhiPrasad@users.noreply.github.com>
…t and opentelemetry (#13640)

Looks like we overlooked two packages when updating deps previously in
#13587.

See:
#13587 (comment)

Closes: #13219
I failed to update the description in my PR when we improved the
property name after some discussion in the PR, so the wrong property
name was used in the changelog:


https://github.com/getsentry/sentry-javascript/blob/bcf571d9954094be76a99edbb12c23eff7f7b5dc/packages/node/src/types.ts#L20

Thanks to @torickjdavis for reporting this
[here](#12414 (comment))!
…t and opentelemetry (#13642)

Part 2 because I forgot to update the lockfile in the [previous
PR](#13640).
The shims should only be applied if the globals are not present, else it
results in double decl and a runtime error. The profiling SDK should
gracefully handle env where the shims are already provided.

I couldn't find a way to modify the shim as it is hardcoded in the
plugin we are using so I went with the replace plugin approach and a
placeholder value #poormansmacros.
…ariables to exceptions (#13501)

Closes #13415

This PR only modifies the async version of this integration which is
used for Node > v19. I tried applying similar changes to the sync
integration and I cannot get it to work without causing memory leaks.

@Bruno-DaSilva has been helping me explore different ways to fix a few
fundamental issues with the local variables integration. Bruno found a
way to [write to the error
object](#13415 (comment))
from the debugger which removes any ambiguity over which variables go
with which exception.

This allows us to remove the stack parsing and hashing which we were
using previously to match up exceptions.

Rather than write the `objectId` to the error, I have used this to write
the entire local variables array directly to the error object. This
completely negates the need to post the local variables from the worker
thread which removes any possibility of race conditions. We then later
pull the local variables directly from
`hint.originalException.__SENTRY_ERROR_LOCAL_VARIABLES__`.
On app router, transactions like `GET /404` get created that we don't
like.
…3631)

resolves #13627

In 1.26.0 otel-js has updated the deprecations for the attributes based
on the new changes to semantic conventions.

They also changed the name of some exports, for example:
`SEMATTRS_HTTP_ROUTE` -> `ATTR_HTTP_ROUTE`. Some exports names were not
able to be changed because they are imported from a subpath export
@opentelemetry/semantic-conventions/incubating. This subpath breaks some
bundling setups, so we are unable to use it.
@AbhiPrasad AbhiPrasad requested a review from a team September 10, 2024 11:59
@AbhiPrasad AbhiPrasad self-assigned this Sep 10, 2024
@AbhiPrasad AbhiPrasad requested review from lforst, andreiborza and mydea and removed request for a team September 10, 2024 11:59
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@AbhiPrasad AbhiPrasad changed the base branch from develop to master September 10, 2024 12:37
@AbhiPrasad
Copy link
Member Author

Woops - good catch @mydea on the missing parts. Updated and also changed branch to point at master.

@AbhiPrasad
Copy link
Member Author

waiting on #13649

Lms24 and others added 3 commits September 10, 2024 13:07
Fix a bug in the initial experimental CLS standalone span
implementation. Previously we'd add the CLS start timestamp value in ms
to the performance time origin timestamp which was already converted to
seconds. Ensure that we first add time origin and the CLS start timestamp 
and then convert to seconds

---------

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Follow up to #13608,
after some tweaks and a rebase!

* When a PR is opened in draft mode, move to "In Progress" on the board
* When a PR is opened for review, move to "In Review" on the board
* When a PR is closed but not merged, move it directly to "Done"
(instead of "Ready for Release")

Note that for now, this only applies to PRs that are on the board
themselves, not to PRs linked to an issue.
@AbhiPrasad
Copy link
Member Author

updated branch to include a2d1b2c

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.52 KB added added
@sentry/browser - with treeshaking flags 21.3 KB added added
@sentry/browser (incl. Tracing) 34.78 KB added added
@sentry/browser (incl. Tracing, Replay) 71.23 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.66 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 75.58 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.3 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.14 KB added added
@sentry/browser (incl. metrics) 26.83 KB added added
@sentry/browser (incl. Feedback) 39.6 KB added added
@sentry/browser (incl. sendFeedback) 27.19 KB added added
@sentry/browser (incl. FeedbackAsync) 31.9 KB added added
@sentry/react 25.28 KB added added
@sentry/react (incl. Tracing) 37.75 KB added added
@sentry/vue 26.72 KB added added
@sentry/vue (incl. Tracing) 36.66 KB added added
@sentry/svelte 22.65 KB added added
CDN Bundle 23.77 KB added added
CDN Bundle (incl. Tracing) 36.49 KB added added
CDN Bundle (incl. Tracing, Replay) 70.91 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.22 KB added added
CDN Bundle - uncompressed 69.63 KB added added
CDN Bundle (incl. Tracing) - uncompressed 108.2 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.87 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.06 KB added added
@sentry/nextjs (client) 37.51 KB added added
@sentry/sveltekit (client) 35.36 KB added added
@sentry/node 120.45 KB added added
@sentry/node - without tracing 92.72 KB added added
@sentry/aws-serverless 102.42 KB added added

@AbhiPrasad AbhiPrasad merged commit 7750a3f into master Sep 10, 2024
154 checks passed
@AbhiPrasad AbhiPrasad deleted the prepare-release/8.30.0 branch September 10, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opentelemetry problem in 8.29 : Error ELSPROBLEMS