Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Attach the DSC to error events #1522

Merged
merged 4 commits into from
May 3, 2023
Merged

ref: Attach the DSC to error events #1522

merged 4 commits into from
May 3, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented May 3, 2023

Attach the DSC to error events as well. This will only be the case if the performance feature is enabled, as sending the DSC requires the use of envelopes, sent to the envelope endpoint.

Refs https://github.com/getsentry/team-replay/issues/70 and getsentry/team-webplatform-meta#45

@cleptric cleptric self-assigned this May 3, 2023
@cleptric cleptric marked this pull request as ready for review May 3, 2023 09:31
@cleptric cleptric requested a review from stayallive May 3, 2023 09:31
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cleptric cleptric merged commit 4e6fae3 into master May 3, 2023
@cleptric cleptric deleted the apply-dsc-to-errors branch May 3, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants