Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin httpx till upstream gets resolved #3465

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Pin httpx till upstream gets resolved #3465

merged 1 commit into from
Aug 27, 2024

Conversation

sl0thentr0py
Copy link
Member

starlette CI is broken with

 module 'httpx._types' has no attribute 'URLTypes' 

caused by this change
github.com/encode/httpx/pull/3245

upstream discussion: encode/httpx#3287

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) August 27, 2024 12:15
@sl0thentr0py sl0thentr0py merged commit 306c34e into master Aug 27, 2024
122 of 123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/pin-httpx branch August 27, 2024 12:24
Copy link

codecov bot commented Aug 27, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
11370 4 11366 1635
View the top 3 failed tests by shortest run time
tests.integrations.aws_lambda.test_aws test_init_error[python3.12]
Stack Traces | 12.4s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.11]
Stack Traces | 17.1s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.10]
Stack Traces | 17.3s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

sl0thentr0py added a commit that referenced this pull request Aug 27, 2024
sl0thentr0py added a commit that referenced this pull request Aug 27, 2024
sl0thentr0py added a commit that referenced this pull request Aug 27, 2024
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants