Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not mark InternalBytecode.js as in_app frame #3348

Closed
krystofwoldrich opened this issue Oct 17, 2023 · 0 comments · Fixed by #3518
Closed

Do not mark InternalBytecode.js as in_app frame #3348

krystofwoldrich opened this issue Oct 17, 2023 · 0 comments · Fixed by #3518
Assignees
@lucas-zimerman
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

Description

React Native applications with Hermes include InternalBytecode.js

https://github.com/krystofwoldrich/hermes/blob/4bcd62206c672c5b9674cab1399931ae8c275829/lib/InternalBytecode/InternalBytecode.cpp#L14

Screenshot 2023-10-17 at 12 40 10

At the moment these frames are marked as in_app: true, but they should not be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-zimerman lucas-zimerman

Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: React-Native
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: errors from InternalBytecode.js are no longer marked as in_app getsentry/sentry-react-native
2 participants
@lucas-zimerman @krystofwoldrich