-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors from InternalBytecode.js are no longer marked as in_app #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-zimerman
changed the title
test
fix: errors from InternalBytecode.js are no longer marked as in_app
Jan 11, 2024
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2534337 | 394.15 ms | 415.12 ms | 20.97 ms |
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
12427f4 | 393.69 ms | 414.84 ms | 21.14 ms |
d361d38 | 354.10 ms | 381.69 ms | 27.59 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
abb7058 | 370.27 ms | 389.58 ms | 19.31 ms |
34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
22e31b6 | 396.48 ms | 419.64 ms | 23.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2534337 | 17.73 MiB | 19.84 MiB | 2.11 MiB |
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
12427f4 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
d361d38 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
abb7058 | 17.73 MiB | 19.83 MiB | 2.10 MiB |
34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
22e31b6 | 17.73 MiB | 19.84 MiB | 2.10 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9433f35+dirty | 1246.94 ms | 1271.45 ms | 24.52 ms |
9c48b2c+dirty | 1246.96 ms | 1255.73 ms | 8.77 ms |
1d86dd6+dirty | 1249.71 ms | 1279.16 ms | 29.45 ms |
d361d38+dirty | 1246.04 ms | 1267.12 ms | 21.08 ms |
12427f4+dirty | 1267.15 ms | 1271.30 ms | 4.15 ms |
6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
3ffcddd+dirty | 1244.47 ms | 1264.14 ms | 19.67 ms |
22e31b6+dirty | 1253.62 ms | 1265.96 ms | 12.34 ms |
0677344+dirty | 1276.70 ms | 1300.07 ms | 23.37 ms |
3853f43+dirty | 1221.82 ms | 1242.64 ms | 20.82 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9433f35+dirty | 2.36 MiB | 2.85 MiB | 499.80 KiB |
9c48b2c+dirty | 2.36 MiB | 2.85 MiB | 495.77 KiB |
1d86dd6+dirty | 2.36 MiB | 2.89 MiB | 535.43 KiB |
d361d38+dirty | 2.36 MiB | 2.85 MiB | 499.84 KiB |
12427f4+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
3ffcddd+dirty | 2.36 MiB | 2.84 MiB | 489.60 KiB |
22e31b6+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
0677344+dirty | 2.36 MiB | 2.85 MiB | 496.81 KiB |
3853f43+dirty | 2.36 MiB | 2.85 MiB | 499.81 KiB |
krystofwoldrich
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
By default InternalBytecode is marked as inApp but in reality it's an generated file outside of the user code so it should be flagged as false.
closes #3348
💡 Motivation and Context
💚 How did you test it?
I haven't found in time an error that could be reproduced so instead, I retrieved from the internet the raw Stack Trace with users that had errors with the
InternalBytecode
, made a test with it and then I fixed therewriteStackFrame
in order to pass the test.📝 Checklist
sendDefaultPII
is enabled🔮 Next steps