ref(js): Use Scope class rather than Scope type for top-level functions

[lobsterkatie]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

This switches the functions defined in sdk.ts from using the Scope interface for typing to using the Scope class for typing, so that the types of withScope here and withScope from the main JS repo match.

💡 Motivation and Context

Fixes getsentry/sentry-javascript#6217.

I steered the OP of the above issue toward a different approach, so in the end he may avoid this problem regardless, but the error he was getting points out the mismatched types.

💚 How did you test it?

I have not tested it. Total mea culpa, I didn't want to go through and set up a whole RN SDK dev environment just for this tiny change, so I did it through the GH UI. I'm hoping that one of my esteemed colleagues might be willing to test it out and see if I've messed up the types anywhere else in the SDK. 🙏🏻

I'll leave this a draft for now, until it's tested.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

I guess conceivably this could be a breaking change, but only if someone has explicitly typed their withScope callback, which feels pretty unlikely.

🔮 Next steps

Figure out if any other types need to be changed elsewhere in the SDK.

[krystofwoldrich]

LGTM. I would keep it as a fix, the specific withScope is quite a recent change in RN, before that we were just reexporting the one from JS.

[lobsterkatie]

LGTM. I would keep it as a fix, the specific withScope is quite a recent change in RN, before that we were just reexporting the one from JS.

Great. Thanks for testing it out, @krystofwoldrich! Feel free to merge this (or I can do it once CI passes and I get back from walking the dogs).