Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contexts): Sync native iOS contexts to JS #2713

Merged
merged 20 commits into from
Jan 16, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 21, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This might be a breaking change due to the inclusion of the event.fingerprint.

💡 Motivation and Context

closes: #2085

💚 How did you test it?

integration tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Check breadcrumbs timestamps

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1b979e1

@krystofwoldrich krystofwoldrich marked this pull request as ready for review January 3, 2023 14:31
src/js/breadcrumb.ts Outdated Show resolved Hide resolved
ios/RNSentry.m Outdated Show resolved Hide resolved
ios/RNSentry.m Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich changed the base branch from main to 5.0.0 January 4, 2023 10:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 324.60 ms 334.36 ms 9.76 ms
Size 17.73 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 339.52 ms 369.84 ms 30.32 ms
d091239+dirty 425.61 ms 447.11 ms 21.50 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d091239+dirty 17.73 MiB 19.95 MiB 2.22 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 291.24 ms 368.18 ms 76.94 ms
Size 7.15 MiB 8.13 MiB 1003.20 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 321.42 ms 342.74 ms 21.32 ms
d091239+dirty 340.16 ms 366.42 ms 26.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d091239+dirty 7.15 MiB 8.00 MiB 874.38 KiB

@krystofwoldrich
Copy link
Member Author

The E2E tests are fixed here #2687.

Otherwise, this is ready.

@krystofwoldrich krystofwoldrich merged commit c022e6f into 5.0.0 Jan 16, 2023
@krystofwoldrich krystofwoldrich deleted the feat/sync-native-up-ios branch January 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append missing context from Native SDK for iOS
2 participants