fix(screenshots): Run take screenshot on ui thread always #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
commented
Jan 12, 2023
marandaneto
reviewed
Jan 12, 2023
marandaneto
reviewed
Jan 12, 2023
marandaneto
reviewed
Jan 20, 2023
marandaneto
reviewed
Jan 20, 2023
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
…to fix-screenshots-on-ui-thread
marandaneto
approved these changes
Jan 23, 2023
krystofwoldrich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The error log appears only in dev builds but suggests that the screenshots should be taken on the UI thread.
💡 Motivation and Context
fixes: #2742
💚 How did you test it?
sample app
📝 Checklist
🔮 Next steps