Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.7.0 #3056

Merged
merged 1 commit into from
May 12, 2023
Merged

chore(deps): update Cocoa SDK to v8.7.0 #3056

merged 1 commit into from
May 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2023

Bumps scripts/update-cocoa.sh from 8.6.0 to 8.7.0.

Auto-generated by a dependency updater.

Changelog

8.7.0

Features

  • Allow starting the SDK with an initial scope (#2982)
  • Swift Error Names (#2960)
enum LoginError: Error {
    case wrongUser(id: String)
    case wrongPassword
}

SentrySDK.capture(error: LoginError.wrongUser("12345678"))

For the Swift error above Sentry displays:

sentry-cocoa SDK Title Description
Since 8.7.0 LoginError wrongUser(id: "12345678") (Code: 1)
Before 8.7.0 LoginError Code: 1

Customized error descriptions have precedence over this feature.
This change has no impact on grouping of the issues in Sentry.

Fixes

  • Propagate span when copying scope (#2952)
  • Remove "/" from crash report file name (#3005)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 9, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 7ab58eb to 2449803 Compare May 9, 2023 13:22
@github-actions
Copy link
Contributor Author

github-actions bot commented May 9, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1285.84 ms 1298.39 ms 12.55 ms
Size 2.92 MiB 3.41 MiB 499.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
86d6d2c+dirty 1291.62 ms 1296.80 ms 5.18 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
86d6d2c+dirty 2.92 MiB 3.37 MiB 464.31 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1263.68 ms 1273.90 ms 10.22 ms
94f9b87+dirty 1269.94 ms 1273.11 ms 3.17 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.92 MiB 3.38 MiB 474.71 KiB
94f9b87+dirty 2.92 MiB 3.39 MiB 485.98 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented May 9, 2023 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 275.52 ms 282.20 ms 6.68 ms
Size 7.15 MiB 8.05 MiB 920.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms
94f9b87+dirty 300.47 ms 353.74 ms 53.27 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB
94f9b87+dirty 7.15 MiB 8.03 MiB 901.79 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented May 12, 2023 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 355.10 ms 379.98 ms 24.88 ms
Size 17.73 MiB 19.76 MiB 2.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 385.21 ms 422.36 ms 37.15 ms
94f9b87+dirty 319.37 ms 330.10 ms 10.73 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 17.73 MiB 20.04 MiB 2.31 MiB
94f9b87+dirty 17.73 MiB 19.75 MiB 2.01 MiB

@github-actions
Copy link
Contributor Author

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.72 ms 1250.50 ms 7.78 ms
Size 2.36 MiB 2.85 MiB 496.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
8da52c9+dirty 1214.59 ms 1224.90 ms 10.31 ms
94f9b87+dirty 1260.32 ms 1283.72 ms 23.40 ms

App size

Revision Plain With Sentry Diff
8da52c9+dirty 2.36 MiB 2.82 MiB 468.48 KiB
94f9b87+dirty 2.36 MiB 2.83 MiB 479.26 KiB

krystofwoldrich
krystofwoldrich approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 01d5710 into main May 12, 2023
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch May 12, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@marandaneto marandaneto Awaiting requested review from marandaneto

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @web-flow