Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): proguardUuid loading #3591

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

💚 How did you test it?

sample app, ci

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.72 ms 428.45 ms 29.73 ms
Size 17.73 MiB 19.90 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3 385.02 ms 387.36 ms 2.34 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
2534337 394.15 ms 415.12 ms 20.97 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
3853f43 329.68 ms 346.32 ms 16.64 ms

App size

Revision Plain With Sentry Diff
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 343.33 ms 357.33 ms 14.00 ms
Size 7.15 MiB 8.18 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB

@krystofwoldrich krystofwoldrich merged commit ae9f909 into main Feb 12, 2024
40 of 45 checks passed
@krystofwoldrich krystofwoldrich deleted the @krystofwoldrich/fix-proguard-uuid-loading branch February 12, 2024 17:21
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.02 ms 1211.18 ms 2.16 ms
Size 2.36 MiB 2.90 MiB 553.21 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants