fix(symbolication): Ignore dev server JSON responses #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3853f43 | 329.68 ms | 346.32 ms | 16.64 ms |
| e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
| 1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| 34aba08 | 328.10 ms | 342.84 ms | 14.74 ms |
| 8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
| e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
| e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
| acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
| ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3853f43 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| 1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 34aba08 | 17.73 MiB | 19.80 MiB | 2.07 MiB |
| 8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
|
Looks good! I quess this will be in next release? |
Seems fixed 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Expo Dev Server without web support behaves differently from the Bare React Native Dev Server and Expo with web support. It always returns 200 HTTP status with JSON config instead of the expected 404 for non-existing endpoints.
Since we are fetching source code context we can ignore the JSON response as the code can not be JSON.
💡 Motivation and Context
fixes: #3602
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps