Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expo-web): Multiple Debug IDs can be loaded into the global polyfill #3660

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 6, 2024

📢 Type of change

  • Bugfix

📜 Description

Expo SDK 50 with React Router can use bundle splitting on the web.

Our RN Debug ID polyfill always created an empty Debug ID carrier when invoked. This deleted previously loaded Debug IDs.

💚 How did you test it?

sample apps

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 666.28 ms 697.17 ms 30.89 ms
Size 17.73 MiB 19.92 MiB 2.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB

Copy link
Contributor

github-actions bot commented Mar 6, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1197.31 ms 1200.02 ms 2.71 ms
Size 2.36 MiB 2.91 MiB 558.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 362.02 ms 386.41 ms 24.39 ms
Size 7.15 MiB 8.19 MiB 1.04 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) March 7, 2024 13:14
@krystofwoldrich krystofwoldrich merged commit 8cabbfa into main Mar 7, 2024
45 of 46 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-debugids-for-split-bundles branch March 7, 2024 13:17
Copy link
Contributor

github-actions bot commented Mar 7, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.29 ms 1218.71 ms 4.42 ms
Size 2.92 MiB 3.47 MiB 569.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
728164b+dirty 1280.06 ms 1285.26 ms 5.20 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
728164b+dirty 2.92 MiB 3.44 MiB 533.26 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expo web not sending debug ids - metro
2 participants