Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update Cocoa SDK to v8.35.0 #4037

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-cocoa.sh from 8.34.0 to 8.35.0.

Auto-generated by a dependency updater.

Changelog

8.35.0

Features

  • Expose span baggage API (#4207)

Fixes

  • Fix SIGABRT when modifying scope user (#4274)
  • Crash during SDK initialization due to corrupted envelope (#4291)
    • Reverts #4219 as potential fix

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Aug 21, 2024
Copy link
Contributor Author

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 466.08 ms 479.08 ms 13.00 ms
Size 17.73 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
baa882f 354.93 ms 356.18 ms 1.25 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
5446992 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
baa882f 17.73 MiB 20.06 MiB 2.33 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e 413.82 ms 445.87 ms 32.05 ms

App size

Revision Plain With Sentry Diff
6a29e9e 17.73 MiB 19.94 MiB 2.21 MiB

Copy link
Contributor Author

github-actions bot commented Aug 21, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 386.54 ms 437.69 ms 51.14 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e+dirty 382.90 ms 420.67 ms 37.77 ms

App size

Revision Plain With Sentry Diff
6a29e9e+dirty 7.15 MiB 8.22 MiB 1.07 MiB

@dylancom
Copy link

Please merge this, getting many crashes due to: getsentry/sentry-cocoa#4280

@krystofwoldrich
Copy link
Member

The iOS builds were failing due to duplicate SentryTraceHeader definition (fixed in a218f44)

@dylancom We will merge and release it shortly.

Copy link
Contributor Author

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.43 ms 1233.31 ms 11.88 ms
Size 2.36 MiB 3.08 MiB 733.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
c398f67+dirty 1219.67 ms 1225.66 ms 5.99 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
c398f67+dirty 2.36 MiB 3.04 MiB 696.27 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e+dirty 1219.98 ms 1223.66 ms 3.68 ms

App size

Revision Plain With Sentry Diff
6a29e9e+dirty 2.36 MiB 3.04 MiB 698.34 KiB

Copy link
Contributor Author

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.23 ms 1222.17 ms -4.06 ms
Size 2.92 MiB 3.64 MiB 738.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
c398f67+dirty 1227.31 ms 1230.00 ms 2.69 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
c398f67+dirty 2.92 MiB 3.60 MiB 701.89 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6a29e9e+dirty 1233.85 ms 1227.88 ms -5.98 ms

App size

Revision Plain With Sentry Diff
6a29e9e+dirty 2.92 MiB 3.61 MiB 705.03 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants