Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install_modules_dependencies for React iOS dependencies #4040

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

oblador
Copy link
Contributor

@oblador oblador commented Aug 22, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #4035

💡 Motivation and Context

install_modules_dependencies helper have been available since 0.71 that determines what react dependencies to add depending on new arch flags etc. This is preferred and would make sure it's forwards and backwards compatible.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Aug 22, 2024

Thank you @oblador for the PR. It looks good, I've returned the dependencies for the else branch when the install_modules_dependencies function is not available, not to introduce any breaking changes for older RN versions with new architecture. (Likely very small group is any, but we can't introduce a breaking change in fixup version)

We should do this regardless #4035.

I've tried the fix with new RN 0.75 application, but I'm still getting the error from #4035

Update: Just a poisoned cache. The fix works. Thank you.

@krystofwoldrich krystofwoldrich changed the title Use install_modules_dependencies for React iOS dependencies Use install_modules_dependencies for React iOS dependencies Aug 22, 2024
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ReactCommon/RCTTurboModule.h' file not found RN 0.75 New Architecture
2 participants