Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes:
I've added two changes:
1st
name.to_s
cause one may provide hash with symbols toload_from_hash
andname
ends up being a symbol, and then it ends up raising an error insentry-ruby/lib/sentry/hub.rb
cause it expects a string...2nd change is much more important though, it's required to support natural-language-format, because the current version doesn't create a monitor successfully. natural language format is something like
every 5 minutes
which gets translated to'*/5 * * * *'
as you can see it in the testshttps://github.com/sidekiq-cron/sidekiq-cron?tab=readme-ov-file#natural-language-formats