fix: Unable to use sentry when URI contains non-ascii symbols on Net::HTTP traces. #2417
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now sentry is not capable of sending traces that contain non ascii characters due to it's usage of `URI.parse`. It will not accept characters like å, ø or æ
rascencio-kraft
changed the title
rascencio-kraft
changed the title
rascencio-kraft
changed the title
…m for Net::HTTPRequest Signed-off-by: Raul Ascencio <raul@kraftanmelding.no>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
- Coverage 98.68% 98.67% -0.02%
==========================================
Files 210 210
Lines 13958 13967 +9
==========================================
+ Hits 13775 13782 +7
- Misses 183 185 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2418
Using URI::DEFAULT_PARSER.escape to properly escape the constructed URLs, which prevents issues with special characters that may cause errors during URI parsing.
Changelog