Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added custom options configuration to samples #568

Merged
merged 6 commits into from
Feb 16, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 16, 2022

Unfortunately, we ship our sample with just the scenes and scripts. So the user has to add an instance of the scriptable object to their own configuration window by hand.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6748098

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

bitsandfoxes and others added 2 commits February 16, 2022 18:06
…n.cs

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
…n.cs

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@bitsandfoxes bitsandfoxes merged commit fce257a into main Feb 16, 2022
@bitsandfoxes bitsandfoxes deleted the feat/config-samples branch February 16, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants