update onchange

getsentry · Oct 8, 2024 · 2eb2c7e · 2eb2c7e
1 parent 5cf214e
commit 2eb2c7e
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 26 deletions.
diff --git a/static/app/components/organizations/datePageFilter.tsx b/static/app/components/organizations/datePageFilter.tsx
@@ -2,9 +2,6 @@ import {updateDateTime} from 'sentry/actionCreators/pageFilters';
 import type {TimeRangeSelectorProps} from 'sentry/components/timeRangeSelector';
 import {TimeRangeSelector} from 'sentry/components/timeRangeSelector';
 import {t} from 'sentry/locale';
-import {trackAnalytics} from 'sentry/utils/analytics';
-import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
-import useOrganization from 'sentry/utils/useOrganization';
 import usePageFilters from 'sentry/utils/usePageFilters';
 import useRouter from 'sentry/utils/useRouter';
 
@@ -36,7 +33,6 @@ export function DatePageFilter({
   const {selection, desyncedFilters, isReady: pageFilterIsReady} = usePageFilters();
   const {start, end, period, utc} = selection.datetime;
   const desynced = desyncedFilters.has('datetime');
-  const organization = useOrganization();
 
   return (
     <TimeRangeSelector
@@ -53,13 +49,6 @@ export function DatePageFilter({
 
         onChange?.(timePeriodUpdate);
 
-        if (getRouteStringFromRoutes(router.routes).includes('dashboardsId')) {
-          trackAnalytics('dashboards2.filter.change', {
-            organization,
-            filter_type: 'day',
-          });
-        }
-
         updateDateTime(newTimePeriod, router, {
           save: true,
           resetParams: resetParamsOnChange,

diff --git a/static/app/components/organizations/environmentPageFilter/index.tsx b/static/app/components/organizations/environmentPageFilter/index.tsx
@@ -124,12 +124,6 @@ export function EnvironmentPageFilter({
         path: getRouteStringFromRoutes(router.routes),
         organization,
       });
-      if (getRouteStringFromRoutes(router.routes).includes('dashboardsId')) {
-        trackAnalytics('dashboards2.filter.change', {
-          organization,
-          filter_type: 'environment',
-        });
-      }
 
       // Wait for the menu to close before calling onChange
       await new Promise(resolve => setTimeout(resolve, 0));

diff --git a/static/app/components/organizations/projectPageFilter/index.tsx b/static/app/components/organizations/projectPageFilter/index.tsx
@@ -203,12 +203,6 @@ export function ProjectPageFilter({
         organization,
         multi: allowMultiple,
       });
-      if (getRouteStringFromRoutes(routes).includes('dashboardsId')) {
-        trackAnalytics('dashboards2.filter.change', {
-          organization,
-          filter_type: 'project',
-        });
-      }
 
       // Wait for the menu to close before calling onChange
       await new Promise(resolve => setTimeout(resolve, 0));

diff --git a/static/app/views/dashboards/filtersBar.tsx b/static/app/views/dashboards/filtersBar.tsx
@@ -11,6 +11,7 @@ import {ProjectPageFilter} from 'sentry/components/organizations/projectPageFilt
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
 import {defined} from 'sentry/utils';
+import {trackAnalytics} from 'sentry/utils/analytics';
 import {ToggleOnDemand} from 'sentry/utils/performance/contexts/onDemandControl';
 import {decodeList} from 'sentry/utils/queryString';
 import {ReleasesProvider} from 'sentry/utils/releases/releasesProvider';
@@ -53,9 +54,33 @@ export default function FiltersBar({
   return (
     <Wrapper>
       <PageFilterBar condensed>
-        <ProjectPageFilter disabled={isEditingDashboard} />
-        <EnvironmentPageFilter disabled={isEditingDashboard} />
-        <DatePageFilter disabled={isEditingDashboard} />
+        <ProjectPageFilter
+          disabled={isEditingDashboard}
+          onChange={() => {
+            trackAnalytics('dashboards2.filter.change', {
+              organization,
+              filter_type: 'project',
+            });
+          }}
+        />
+        <EnvironmentPageFilter
+          disabled={isEditingDashboard}
+          onChange={() => {
+            trackAnalytics('dashboards2.filter.change', {
+              organization,
+              filter_type: 'environment',
+            });
+          }}
+        />
+        <DatePageFilter
+          disabled={isEditingDashboard}
+          onChange={() => {
+            trackAnalytics('dashboards2.filter.change', {
+              organization,
+              filter_type: 'date',
+            });
+          }}
+        />
       </PageFilterBar>
       <Fragment>
         <FilterButtons>