-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(weekly-reports): dupe on report timestamp instead of batch (#76031)
- It has been observed that a portion of our duplicate weekly emails come from the schedule celery task being killed and restarted, which will cause duplicates for any orgs that were queued in the first batch. - this also generates a new batch_id, which causes our de-duplication logic to not work, as batch_id is included in the redis key that we use. - [x] This PR modifies our logic so that the dupe checker instead uses the timestamp for which the weekly report is generated on. this should be a safe way to ensure no duplicates occur across batches. - [x] Updates the test.
- Loading branch information
Showing
2 changed files
with
19 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters