Skip to content

Commit

Permalink
fix(codeowners): Clean up CODEOWNERS
Browse files Browse the repository at this point in the history
The result of a hackweek project which didn't make it too far...

More details below, in general these fixes fall into two buckets:
- Duplicate patterns: Later rules override earlier rules so the first
  ones were being ignored.
- Missing files: Rules which never applied to any files. These files
  were some combination of moved and deleted.

```
$ codeberg lint ../sentry | grep -v NoUnownedFiles
[NoMissingFiles] 19: /src/sentry/utils/snql.py does not match any files
[NoMissingFiles] 60: /src/sentry/web/frontend/auth_organization_id_login.py does not match any files
[NoMissingFiles] 98: /src/sentry/api/endpoints/relocation/ does not match any files
[NoMissingFiles] 99: /src/sentry/api/serialiers/models/relocation/ does not match any files
[NoMissingFiles] 100: /src/sentry/models/relocation/ does not match any files
[NoMissingFiles] 104: /tests/sentry/api/endpoints/relocation does not match any files
[NoMissingFiles] 106: /tests/sentry/api/serializer/test_relocation.py does not match any files
[NoMissingFiles] 118: .vercel.json does not match any files
[NoMissingFiles] 119: /.githib/worksflows/frontend.yml does not match any files
[NoMissingFiles] 146: /src/sentry/utils/monitors.py does not match any files
[NoMissingFiles] 147: /tests/sentry/utils/test_monitors.py does not match any files
[NoMissingFiles] 162: /src/sentry/api/endpoints/internal/integration_proxy.py does not match any files
[NoMissingFiles] 164: /src/sentry/models/outbox.py does not match any files
[NoMissingFiles] 165: /src/sentry/tasks/deliver_from_outbox.py does not match any files
[NoMissingFiles] 225: /tests/snuba/api/endpoints/test_organization_events_trends_v2.py does not match any files
[NoMissingFiles] 313: /src/sentry/utils/profiling.py does not match any files
[NoMissingFiles] 368: /src/sentry/tasks/weekly_reports.py does not match any files
[NoMissingFiles] 390: /src/sentry/models/organizationoption.py does not match any files
[NoMissingFiles] 392: /src/sentry/models/projectoption.py does not match any files
[NoDuplicatePatterns] 412: /src/sentry/web/frontend/auth_login.py duplicated on line 58
[NoMissingFiles] 421: /tests/sentry/api/test_scim*.py does not match any files
[NoMissingFiles] 445: /tests/sentry/api/endpoints/test_projects_metrics_visibility.py does not match any files
[NoMissingFiles] 451: /src/sentry/api/endpoints/organization_ddm.py does not match any files
[NoMissingFiles] 452: /tests/sentry/api/endpoints/test_organization_ddm_meta.py does not match any files
[NoMissingFiles] 457: /src/sentry/api/endpoints/projects_metrics.py does not match any files
[NoDuplicatePatterns] 477: /src/sentry/snuba/metrics/ duplicated on line 27
[NoMissingFiles] 482: /static/app/actionCreators/metrics.spec.tsx does not match any files
[NoMissingFiles] 492: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracy.spec.tsx does not match any files
[NoMissingFiles] 493: /static/app/views/performance/landing/dynamicSamplingMetricsAccuracyAlert.tsx does not match any files
[NoMissingFiles] 554: /static/app/components/modals/autofixSetupModal.spec.tsx does not match any files
[NoMissingFiles] 555: /static/app/components/modals/autofixSetupModal.tsx does not match any files
[NoMissingFiles] 568: /src/sentry/tasks/low_priority_symbolication.py does not match any files
[NoMissingFiles] 570: /tests/sentry/tasks/test_low_priority_symbolication.py does not match any files
[NoMissingFiles] 571: /src/sentry/tasks/reprocessing.py does not match any files
[NoMissingFiles] 580: /src/sentry/tasks/invite_missing_org_members.py does not match any files
[NoMissingFiles] 582: /src/sentry/tasks/integrations/github/pr_comment.py does not match any files
```
  • Loading branch information
mrduncan committed Aug 22, 2024
1 parent 9edbb44 commit 3c2e416
Showing 1 changed file with 23 additions and 47 deletions.
70 changes: 23 additions & 47 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
/src/sentry/consumers/ @getsentry/ops @getsentry/owners-snuba
/src/sentry/post_process_forwarder/ @getsentry/owners-snuba
/src/sentry/utils/snuba.py @getsentry/owners-snuba @getsentry/visibility
/src/sentry/utils/snql.py @getsentry/owners-snuba
/src/sentry/utils/arroyo.py @getsentry/owners-snuba
/src/sentry/utils/arroyo_producer.py @getsentry/owners-snuba
/src/sentry/tsdb/snuba.py @getsentry/owners-snuba
Expand All @@ -26,6 +25,7 @@
/tests/sentry/sentry_metrics/ @getsentry/owners-snuba
/src/sentry/snuba/metrics/ @getsentry/owners-snuba @getsentry/telemetry-experience
/src/sentry/snuba/metrics/query.py @getsentry/owners-snuba @getsentry/telemetry-experience
/src/sentry/snuba/metrics/fields/snql.py @getsentry/owners-snuba
/src/sentry/snuba/metrics_layer/ @getsentry/owners-snuba
/src/sentry/search/events/datasets/metrics_layer.py @getsentry/owners-snuba

Expand Down Expand Up @@ -55,9 +55,8 @@
/src/sentry/api/endpoints/auth* @getsentry/security @getsentry/enterprise
/src/sentry/api/endpoints/user_permission* @getsentry/security @getsentry/enterprise
/src/sentry/web/frontend/auth_close.py @getsentry/security
/src/sentry/web/frontend/auth_login.py @getsentry/security
/src/sentry/web/frontend/auth_login.py @getsentry/security @getsentry/enterprise
/src/sentry/web/frontend/auth_logout.py @getsentry/security
/src/sentry/web/frontend/auth_organization_id_login.py @getsentry/security
/src/sentry/web/frontend/auth_organization_login.py @getsentry/security
/src/sentry/web/frontend/auth_provider_login.py @getsentry/security
/src/sentry/web/frontend/oauth_token.py @getsentry/security
Expand Down Expand Up @@ -95,15 +94,15 @@ Makefile @getsentry/owners-sentr
## Relocation - getsentry/team-ospo#153
/src/sentry/analytics/events/relocation_*.py @getsentry/open-source
/src/sentry/api/endpoints/organization_fork.py @getsentry/open-source
/src/sentry/api/endpoints/relocation/ @getsentry/open-source
/src/sentry/api/serialiers/models/relocation/ @getsentry/open-source
/src/sentry/models/relocation/ @getsentry/open-source
/src/sentry/api/endpoints/relocations/ @getsentry/open-source
/src/sentry/api/serializers/models/relocation.py @getsentry/open-source
/src/sentry/models/relocation.py @getsentry/open-source
/src/sentry/relocation/ @getsentry/open-source
/src/sentry/tasks/relocation.py @getsentry/open-source
/src/sentry/utils/relocation.py @getsentry/open-source
/tests/sentry/api/endpoints/relocation @getsentry/open-source
/tests/sentry/api/endpoints/relocations/ @getsentry/open-source
/tests/sentry/api/endpoints/test_organization_fork.py @getsentry/open-source
/tests/sentry/api/serializer/test_relocation.py @getsentry/open-source
/tests/sentry/api/serializers/test_relocation.py @getsentry/open-source
/tests/sentry/tasks/test_relocation.py @getsentry/open-source
/tests/sentry/utils/test_relocation.py @getsentry/open-source

Expand All @@ -115,8 +114,7 @@ Makefile @getsentry/owners-sentr
setup.cfg @getsentry/release-approvers
requirements*.txt @getsentry/owners-python-build
pyproject.toml @getsentry/owners-python-build
.vercel.json @getsentry/owners-js-build
/.githib/worksflows/frontend.yml @getsentry/owners-js-build
/.github/workflows/frontend.yml @getsentry/owners-js-build
/.github/file-filters.yml @getsentry/owners-js-build
babel.config.* @getsentry/owners-js-build
biome.json @getsentry/owners-js-build
Expand All @@ -143,8 +141,6 @@ yarn.lock @getsentry/owners-js-de
/static/app/views/monitors @getsentry/crons
/src/sentry/monitors @getsentry/crons
/tests/sentry/monitors @getsentry/crons
/src/sentry/utils/monitors.py @getsentry/crons
/tests/sentry/utils/test_monitors.py @getsentry/crons
## End Crons

## Uptime
Expand All @@ -159,10 +155,7 @@ yarn.lock @getsentry/owners-js-de
/src/sentry/middleware/customer_domain.py @getsentry/hybrid-cloud
/src/sentry/middleware/subdomain.py @getsentry/hybrid-cloud
/src/sentry/middleware/integration/ @getsentry/hybrid-cloud
/src/sentry/api/endpoints/internal/integration_proxy.py @getsentry/hybrid-cloud
/src/sentry/api/endpoints/internal/rpc.py @getsentry/hybrid-cloud
/src/sentry/models/outbox.py @getsentry/hybrid-cloud
/src/sentry/tasks/deliver_from_outbox.py @getsentry/hybrid-cloud
/src/sentry/tasks/deletion/hybrid_cloud.py @getsentry/hybrid-cloud
## End of Hybrid Cloud

Expand Down Expand Up @@ -222,7 +215,6 @@ yarn.lock @getsentry/owners-js-de
/tests/snuba/api/endpoints/test_organization_events_spans_histogram.py @getsentry/visibility
/tests/snuba/api/endpoints/test_organization_events_trace.py @getsentry/visibility
/tests/snuba/api/endpoints/test_organization_events_trends.py @getsentry/visibility
/tests/snuba/api/endpoints/test_organization_events_trends_v2.py @getsentry/visibility
/tests/snuba/api/endpoints/test_organization_events_vitals.py @getsentry/visibility
/tests/snuba/api/endpoints/test_organization_tagkey_values.py @getsentry/visibility

Expand Down Expand Up @@ -310,7 +302,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/static/app/types/profiling.d.ts @getsentry/profiling
/static/app/utils/profiling @getsentry/profiling
/static/app/views/profiling @getsentry/profiling
/src/sentry/utils/profiling.py @getsentry/profiling
/src/sentry/api/endpoints/project_profiling_profile.py @getsentry/profiling
/src/sentry/api/endpoints/organization_profiling_profiles.py @getsentry/profiling
/src/sentry/profiles @getsentry/profiling
Expand Down Expand Up @@ -362,10 +353,10 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge

/src/sentry/models/identity.py @getsentry/enterprise

/src/sentry/tasks/summaries/weekly_reports.py @getsentry/alerts-notifications
/src/sentry/tasks/digests.py @getsentry/alerts-notifications
/src/sentry/tasks/email.py @getsentry/alerts-notifications
/src/sentry/tasks/user_report.py @getsentry/alerts-notifications
/src/sentry/tasks/weekly_reports.py @getsentry/alerts-notifications

/src/sentry_plugins/ @getsentry/product-owners-settings-integrations

Expand All @@ -380,18 +371,18 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge


## Data
/src/sentry/models/featureadoption.py @getsentry/data
/src/sentry/models/group.py @getsentry/data
/src/sentry/models/grouphash.py @getsentry/data
/src/sentry/models/grouprelease.py @getsentry/data
/src/sentry/models/groupresolution.py @getsentry/data
/src/sentry/models/organization.py @getsentry/data
/src/sentry/models/organizationmember.py @getsentry/data
/src/sentry/models/organizationoption.py @getsentry/data
/src/sentry/models/project.py @getsentry/data @getsentry/telemetry-experience
/src/sentry/models/projectoption.py @getsentry/data
/src/sentry/models/release.py @getsentry/data
/src/sentry/models/user.py @getsentry/data
/src/sentry/models/featureadoption.py @getsentry/data
/src/sentry/models/group.py @getsentry/data
/src/sentry/models/grouphash.py @getsentry/data
/src/sentry/models/grouprelease.py @getsentry/data
/src/sentry/models/groupresolution.py @getsentry/data
/src/sentry/models/options/organization_option.py @getsentry/data
/src/sentry/models/options/project_option.py @getsentry/data
/src/sentry/models/organization.py @getsentry/data
/src/sentry/models/organizationmember.py @getsentry/data
/src/sentry/models/project.py @getsentry/data @getsentry/telemetry-experience
/src/sentry/models/release.py @getsentry/data
/src/sentry/models/user.py @getsentry/data
## End of Data


Expand All @@ -409,7 +400,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/src/sentry/models/release_threshold @getsentry/enterprise
/src/sentry/scim/ @getsentry/enterprise
/src/sentry/tasks/integrations/github/ @getsentry/enterprise
/src/sentry/web/frontend/auth_login.py @getsentry/enterprise
/static/app/components/superuserStaffAccessForm.tsx @getsentry/enterprise
/static/app/constants/superuserAccessErrors.tsx @getsentry/enterprise
/static/app/views/organizationStats @getsentry/enterprise
Expand All @@ -418,7 +408,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/tests/sentry/api/endpoints/test_auth*.py @getsentry/enterprise
/tests/sentry/api/endpoints/test_organization_projects_experiment.py @getsentry/enterprise
/tests/sentry/api/test_data_secrecy.py @getsentry/enterprise
/tests/sentry/api/test_scim*.py @getsentry/enterprise
/tests/sentry/auth/test_staff.py @getsentry/enterprise
/tests/sentry/auth/test_superuser.py @getsentry/enterprise
/tests/sentry/middleware/test_staff.py @getsentry/enterprise
Expand Down Expand Up @@ -448,14 +437,11 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge


## Telemetry Experience
/src/sentry/api/endpoints/organization_ddm.py @getsentry/telemetry-experience
/tests/sentry/api/endpoints/test_organization_ddm_meta.py @getsentry/telemetry-experience
/src/sentry/api/endpoints/organization_metric* @getsentry/telemetry-experience
/tests/sentry/api/endpoints/test_organization_metric* @getsentry/telemetry-experience
/src/sentry/api/endpoints/organization_sessions.py @getsentry/telemetry-experience
/tests/snuba/api/endpoints/test_organization_sessions.py @getsentry/telemetry-experience
/src/sentry/api/endpoints/projects_metrics.py @getsentry/telemetry-experience
/tests/sentry/api/endpoints/test_projects_metrics_visibility.py @getsentry/telemetry-experience
/src/sentry/api/endpoints/project_metrics.py @getsentry/telemetry-experience
/src/sentry/api/endpoints/organization_onboarding* @getsentry/telemetry-experience
/tests/sentry/api/endpoints/test_organization_onboarding* @getsentry/telemetry-experience
/src/sentry/api/endpoints/project_metrics_extraction_rules* @getsentry/telemetry-experience
Expand All @@ -474,12 +460,10 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/src/sentry/sentry_metrics/span_attribute_extraction_rules.py @getsentry/telemetry-experience
/src/sentry/sentry_metrics/extraction_rules.py @getsentry/telemetry-experience
/tests/sentry/sentry_metrics/test_extraction_rules.py @getsentry/telemetry-experience
/src/sentry/snuba/metrics/ @getsentry/telemetry-experience
/tests/sentry/snuba/metrics/ @getsentry/telemetry-experience
/src/sentry/relay/config/metric_extraction.py @getsentry/telemetry-experience
/tests/sentry/relay/config/test_metric_extraction.py @getsentry/telemetry-experience

/static/app/actionCreators/metrics.spec.tsx @getsentry/telemetry-experience
/static/app/actionCreators/metrics.tsx @getsentry/telemetry-experience
/static/app/data/platformCategories.tsx @getsentry/telemetry-experience
/static/app/data/platformPickerCategories.tsx @getsentry/telemetry-experience
Expand All @@ -489,8 +473,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/static/app/types/project.tsx @getsentry/telemetry-experience
/static/app/utils/metrics/ @getsentry/telemetry-experience
/static/app/views/metrics/ @getsentry/telemetry-experience
/static/app/views/performance/landing/dynamicSamplingMetricsAccuracy.spec.tsx @getsentry/telemetry-experience
/static/app/views/performance/landing/dynamicSamplingMetricsAccuracyAlert.tsx @getsentry/telemetry-experience
/static/app/views/settings/project/dynamicSampling/ @getsentry/telemetry-experience
/static/app/views/settings/projectMetrics/* @getsentry/telemetry-experience
/static/app/views/onboarding* @getsentry/telemetry-experience
Expand Down Expand Up @@ -551,8 +533,6 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/src/sentry/api/endpoints/event_ai_suggested_fix.py @getsentry/machine-learning-ai
/static/app/components/events/aiSuggestedSolution/ @getsentry/machine-learning-ai
/static/app/components/events/autofix/ @getsentry/machine-learning-ai
/static/app/components/modals/autofixSetupModal.spec.tsx @getsentry/machine-learning-ai
/static/app/components/modals/autofixSetupModal.tsx @getsentry/machine-learning-ai
## End of ML & AI

## Processing
Expand All @@ -565,10 +545,7 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
/src/sentry/lang/native/ @getsentry/ingest
/src/sentry/processing/realtime_metrics/ @getsentry/ingest
/src/sentry/tasks/assemble.py @getsentry/ingest
/src/sentry/tasks/low_priority_symbolication.py @getsentry/ingest
/src/sentry/tasks/symbolication.py @getsentry/ingest
/tests/sentry/tasks/test_low_priority_symbolication.py @getsentry/ingest
/src/sentry/tasks/reprocessing.py @getsentry/ingest
/src/sentry/tasks/reprocessing2.py @getsentry/ingest
/src/sentry/reprocessing2.py @getsentry/ingest
/src/sentry/tasks/store.py @getsentry/ingest
Expand All @@ -577,9 +554,8 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
## Ecosystem
/src/sentry/api/endpoints/notifications/notification_actions* @getsentry/ecosystem
/src/sentry/api/endpoints/organization_missing_org_members.py @getsentry/ecosystem
/src/sentry/tasks/invite_missing_org_members.py @getsentry/ecosystem
/static/app/components/modals/inviteMissingMembersModal/ @getsentry/ecosystem
/src/sentry/tasks/integrations/github/pr_comment.py @getsentry/ecosystem
/src/sentry/integrations/github/tasks/pr_comment.py @getsentry/ecosystem
## End of Ecosystem

## Core Product Foundations
Expand Down

0 comments on commit 3c2e416

Please sign in to comment.