refactor(anomaly detection): improve chart error message

getsentry · Oct 8, 2024 · 48c5e4d · 48c5e4d
1 parent 73cfa3c
commit 48c5e4d
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/static/app/views/alerts/rules/metric/ruleForm.tsx b/static/app/views/alerts/rules/metric/ruleForm.tsx
@@ -1099,12 +1099,20 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
         this.setState(rest);
       }
     } catch (e) {
-      const chartErrorMessage =
-        e.responseJSON && typeof e.responseJSON === 'object'
-          ? e.responseJSON.detail
-          : typeof e.responseJSON === 'string'
-            ? e.responseJSON
-            : e.message || e;
+      let chartErrorMessage: string | undefined;
+      if (e.responseJSON) {
+        if (typeof e.responseJSON === 'object' && e.responseJSON.detail) {
+          chartErrorMessage = e.responseJSON.detail;
+        }
+        if (typeof e.responseJSON === 'string') {
+          chartErrorMessage = e.responseJSON;
+        }
+      } else if (typeof e.message === 'string') {
+        chartErrorMessage = e.message;
+      } else {
+        chartErrorMessage = t('Something went wrong when rendering this chart.');
+      }
+
       this.setState({
         chartError: true,
         chartErrorMessage,