-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use bigint for "times_seen" in "groupedmessage"
this field/column may trigger integer overflow. NB: "times_seen" is indexed field, so issue REINDEX TABLE after changing column type. Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
- Loading branch information
1 parent
f2babf8
commit f9f7c75
Showing
2 changed files
with
52 additions
and
1 deletion.
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
src/sentry/migrations/0749_alter_times_seen_in_groupedmessage.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Generated by Django 5.0.7 on 2024-08-09 15:00 | ||
|
||
from django.db import migrations, models | ||
|
||
from sentry.new_migrations.migrations import CheckedMigration | ||
|
||
|
||
class Migration(CheckedMigration): | ||
# This flag is used to mark that a migration shouldn't be automatically run in production. | ||
# This should only be used for operations where it's safe to run the migration after your | ||
# code has deployed. So this should not be used for most operations that alter the schema | ||
# of a table. | ||
# Here are some things that make sense to mark as post deployment: | ||
# - Large data migrations. Typically we want these to be run manually so that they can be | ||
# monitored and not block the deploy for a long period of time while they run. | ||
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to | ||
# run this outside deployments so that we don't block them. Note that while adding an index | ||
# is a schema change, it's completely safe to run the operation after the code has deployed. | ||
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
||
is_post_deployment = False | ||
|
||
dependencies = [ | ||
("sentry", "0748_alter_score_in_groupedmessage.py"), | ||
] | ||
|
||
operations = [ | ||
migrations.SeparateDatabaseAndState( | ||
database_operations=[ | ||
migrations.RunSQL( | ||
""" | ||
ALTER TABLE "sentry_groupedmessage" ALTER COLUMN "times_seen" TYPE bigint; | ||
REINDEX TABLE "sentry_groupedmessage"; | ||
""", | ||
reverse_sql=""" | ||
UPDATE "sentry_groupedmessage" SET "times_seen" = 2147483647 WHERE "times_seen" > 2147483647; | ||
ALTER TABLE "sentry_groupedmessage" ALTER COLUMN "times_seen" TYPE int; | ||
REINDEX TABLE "sentry_groupedmessage"; | ||
""", | ||
hints={"tables": ["sentry_groupedmessage"]}, | ||
), | ||
], | ||
state_operations=[ | ||
migrations.AlterField( | ||
model_name="group", | ||
name="times_seen", | ||
field=models.PositiveBigIntegerField(db_index=True, null=False), | ||
), | ||
], | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters