Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Team: Crons label #43111

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Add Team: Crons label #43111

merged 5 commits into from
Jan 12, 2023

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jan 11, 2023 •
edited by chadwhitacre
Loading

Removing core-ui and frontend labels

Add Team: Crons label

@hubertdeng123 hubertdeng123 requested a review from a team as a code owner January 11, 2023 18:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited
Loading

🏷 The following changes will be made to the repository labels

Validating provided labels
Fetching labels from GitHub
Labels are already up to date

asottile-sentry
asottile-sentry approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadwhitacre
Copy link
Member

Are the labels empty currently? We should reroute all open tickets before landing this.

@evanpurkhiser
Copy link
Member

unfortunate people are editing these manually 😢

@evanpurkhiser
Copy link
Member

Oh wait this is actually removing them, nvm yeah what chad said

chadwhitacre
chadwhitacre requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@chadwhitacre chadwhitacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reroute open tickets first.

@hubertdeng123
Copy link
Member Author

Currently rerouting tickets as we speak

@chadwhitacre
Copy link
Member

We have getsentry/team-ospo#60 for a bigger cleanup, this is quick fixes because we have a lot of tickets to triage piled up on these old labels (particularly core-ui).

@chadwhitacre
Copy link
Member

FYI decided to keep Core UI.

not-dead-yet

@chadwhitacre
Copy link
Member

We still have 10 open Frontend issues. Since those are all triaged (yes?) and the main reason for this PR was to deal with Core UI which we're now leaving, want to drop the Frontend removal and now make this just about adding Crons? 😅

@hubertdeng123
Copy link
Member Author

Yes, we can deal with frontend and core ui some other time if needed

@chadwhitacre chadwhitacre enabled auto-merge (squash) January 12, 2023 13:36
@chadwhitacre chadwhitacre changed the title Remove team labels that do not exist anymore Add Team: Crons label Jan 12, 2023
@chadwhitacre chadwhitacre merged commit 06b0ae0 into master Jan 12, 2023
@chadwhitacre chadwhitacre deleted the hubertdeng123/update-team-labels branch January 12, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chadwhitacre chadwhitacre chadwhitacre approved these changes

@ethanhs ethanhs ethanhs approved these changes

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hubertdeng123 @chadwhitacre @evanpurkhiser @ethanhs @asottile-sentry