feat(exception-group): Move related exceptions out of the stack trace and sort properly #48167

malwilley · 2023-04-28T17:34:35Z

Related exceptions are now above the stack trace. This simplified the code quite a bit and means we don't need to prop-drill mechanism and isNewestFrame any longer, which is the reason for so many deleted lines.
The child exceptions in the tree are now sorted according to the selected stack trace order preference (newest vs oldest first).

Before:

After:

… and sort children

feat(exception-group): Move related exceptions out of the stack trace…

a787684

… and sort children

malwilley requested review from mattjohnsonpint, priscilawebdev and a team April 28, 2023 17:34

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 28, 2023

malwilley linked an issue Apr 28, 2023 that may be closed by this pull request

Exception Groups: Fix order of tree items #47957

Closed

mattjohnsonpint approved these changes Apr 28, 2023

View reviewed changes

Remove unnecessary prop in test

012342c

malwilley requested a review from a team as a code owner April 28, 2023 23:33

vercel bot deployed to Preview April 28, 2023 23:36 View deployment

malwilley merged commit b49868f into master May 1, 2023

malwilley deleted the malwilley/feat/exception-tree-placement branch May 1, 2023 15:53

This was referenced May 5, 2023

feat(grouping): Exception Groups #48653

Merged

Support Exception Groups #37716

Closed

github-actions bot locked and limited conversation to collaborators May 17, 2023

Provide feedback