feat(severity): Use new escalation logic for archived issues <1 day old #61396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
isabellaenriquez
commented
Dec 7, 2023
isabellaenriquez
commented
Dec 7, 2023
| @@ -1367,7 +1378,10 @@ def detect_new_escalation(job: PostProcessJob): | |||
| ): | |||
| return | |||
| group_age_hours = (datetime.now() - group.first_seen).total_seconds() / 3600 | |||
| if group_age_hours >= MAX_NEW_ESCALATION_AGE_HOURS or group.substatus != GroupSubStatus.NEW: | |||
| has_valid_status = group.substatus == GroupSubStatus.NEW or ( | |||
| group.status == GroupStatus.IGNORED and group.substatus == GroupSubStatus.UNTIL_ESCALATING | |||
There was a problem hiding this comment.
rn there aren't cases where we'd have GroupSubStatus.UNTIL_ESCALATING without GroupStatus.IGNORED but i thought it was worth checking for status any way in case we decided to use the substatus for other things
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #61396 +/- ##
=======================================
Coverage 81.12% 81.12%
=======================================
Files 5191 5191
Lines 227915 227919 +4
Branches 38225 38225
=======================================
+ Hits 184889 184896 +7
+ Misses 37411 37410 -1
+ Partials 5615 5613 -2
|
snigdhas
reviewed
Dec 7, 2023
isabellaenriquez
commented
Dec 7, 2023
| @@ -1366,8 +1374,11 @@ def detect_new_escalation(job: PostProcessJob): | |||
| "projects:first-event-severity-new-escalation", job["event"].project | |||
| ): | |||
| return | |||
| group_age_hours = (datetime.now() - group.first_seen).total_seconds() / 3600 | |||
| if group_age_hours >= MAX_NEW_ESCALATION_AGE_HOURS or group.substatus != GroupSubStatus.NEW: | |||
| group_age_hours = (timezone.now() - group.first_seen).total_seconds() / 3600 | |||
There was a problem hiding this comment.
i think datetime.now() originally worked because our test data had first_seen set with a datetime, but based on the table schema it seems like we save groups with timezone info?
snigdhas
approved these changes
Dec 7, 2023
vartec
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates archived -> escalating issues so that if they are less than a day old, they use the new escalation logic, otherwise they use the existing logic.
This PR also changes the new escalation logic tests to use
timezoneinstead ofdatetimesincefirst_seenonGroupis timezone-aware.Resolves #60418