Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-search): Remove groups.enable-post-update-signal #74607

Closed
wants to merge 1 commit into from

Conversation

snigdhas
Copy link
Member

Remove references to groups.enable-post-update-signal and enable the option globally. This allows us to stop sending custom post-update signals since the call to .update will send the signal inherently.

The option configurations will be removed in followup PR after which the option can be unregistered.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 19, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (b403ecc) to head (7b76356).
Report is 1056 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #74607       +/-   ##
===========================================
+ Coverage   56.96%   77.63%   +20.67%     
===========================================
  Files        6459     6690      +231     
  Lines      285436   299465    +14029     
  Branches    49078    51529     +2451     
===========================================
+ Hits       162597   232504    +69907     
+ Misses     118412    60653    -57759     
- Partials     4427     6308     +1881     
Files Coverage Δ
src/sentry/api/helpers/group_index/update.py 90.17% <100.00%> (+47.48%) ⬆️
src/sentry/db/models/manager/base_query_set.py 84.90% <100.00%> (+39.74%) ⬆️
src/sentry/db/models/query.py 67.25% <100.00%> (+9.99%) ⬆️
src/sentry/issues/escalating.py 91.03% <100.00%> (+35.78%) ⬆️
src/sentry/issues/ongoing.py 100.00% <ø> (+58.62%) ⬆️
src/sentry/issues/status_change.py 93.75% <ø> (+20.67%) ⬆️
src/sentry/models/activity.py 93.81% <ø> (+17.62%) ⬆️
src/sentry/models/group.py 94.87% <100.00%> (+37.89%) ⬆️
src/sentry/options/defaults.py 100.00% <ø> (ø)

... and 2089 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Aug 10, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 10, 2024
@snigdhas snigdhas closed this Aug 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant