Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ghe integration - add additional details in log and capture message #74884

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Jul 24, 2024

For hosts that bypass the signature check:

  • add additional details to the log output
  • capture a message and send it to Sentry

@mdtro mdtro requested a review from a team as a code owner July 24, 2024 19:46
@mdtro mdtro requested a review from a team July 24, 2024 19:46
@mdtro mdtro changed the title fix: add additional details in log and capture message fix: ghe integration - add additional details in log and capture message Jul 24, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (f65b4f3) to head (a12d174).
Report is 1021 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74884   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files        6743     6743           
  Lines      300966   300982   +16     
  Branches    51766    51769    +3     
=======================================
+ Hits       235125   235154   +29     
+ Misses      59499    59491    -8     
+ Partials     6342     6337    -5     
Files Coverage Δ
...c/sentry/integrations/github_enterprise/webhook.py 87.50% <100.00%> (+0.19%) ⬆️

... and 12 files with indirect coverage changes

@mdtro mdtro enabled auto-merge (squash) July 24, 2024 22:14
@getsantry
Copy link
Contributor

getsantry bot commented Aug 15, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 15, 2024
@getsantry getsantry bot closed this Aug 23, 2024
auto-merge was automatically disabled August 23, 2024 07:00

Pull request was closed

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
@mdtro mdtro reopened this Sep 20, 2024
@mdtro mdtro requested a review from a team as a code owner September 20, 2024 18:12
@getsantry getsantry bot removed the Stale label Sep 21, 2024
@mdtro mdtro merged commit 48f2370 into master Sep 23, 2024
50 checks passed
@mdtro mdtro deleted the mdtro/ghe-webhook-logging branch September 23, 2024 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants