Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(relay): Remove sentry:relay-rev for project configs #75521

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Aug 2, 2024

See: getsentry/relay#3887

Replaces the sentry:relay-rev with just a unique id per generation.

#skip-changelog

@Dav1dde Dav1dde requested review from a team as code owners August 2, 2024 08:39
@Dav1dde Dav1dde self-assigned this Aug 2, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.23%. Comparing base (eb7b3ec) to head (fa9d601).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75521      +/-   ##
==========================================
+ Coverage   77.34%   78.23%   +0.89%     
==========================================
  Files        6819     6821       +2     
  Lines      302757   302928     +171     
  Branches    52110    52137      +27     
==========================================
+ Hits       234159   236994    +2835     
+ Misses      62055    59564    -2491     
+ Partials     6543     6370     -173     
Files Coverage Δ
src/sentry/models/project.py 94.62% <ø> (+0.21%) ⬆️
src/sentry/projectoptions/__init__.py 100.00% <ø> (ø)
src/sentry/projectoptions/manager.py 80.00% <ø> (+0.40%) ⬆️
src/sentry/relay/config/__init__.py 90.30% <ø> (ø)

... and 222 files with indirect coverage changes

@Dav1dde Dav1dde requested a review from a team as a code owner August 5, 2024 06:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Aug 5, 2024

Bundle Report

Changes will increase total bundle size by 26.18kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.64MB 26.18kB ⬆️

@Dav1dde Dav1dde enabled auto-merge (squash) August 5, 2024 11:06
@Dav1dde Dav1dde merged commit ca62842 into master Aug 5, 2024
49 checks passed
@Dav1dde Dav1dde deleted the dav1d/relay-rev branch August 5, 2024 11:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants