chore(hybridcloud) Move outbox tasks to sentry.hybridcloud #75739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate more outbox subsystem logic into sentry.hybridcloud.
github-actions
bot
added
the
Scope: Backend
markstory
commented
Aug 7, 2024
Comment on lines
+740
to
+741
| "sentry.hybridcloud.tasks.backfill_outboxes", | ||
| "sentry.hybridcloud.tasks.deliver_from_outbox", |
There was a problem hiding this comment.
The tasks didn't have their names changed, so updating CELERY_IMPORTS should be all that is necessary for tasks to continue executing without interruption.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #75739 +/- ##
==========================================
- Coverage 78.25% 78.24% -0.01%
==========================================
Files 6838 6815 -23
Lines 303803 303669 -134
Branches 52271 52232 -39
==========================================
- Hits 237730 237604 -126
+ Misses 59693 59681 -12
- Partials 6380 6384 +4
|
GabeVillalobos
approved these changes
Aug 9, 2024
| @@ -78,7 +80,7 @@ def test_region_processing(task_runner): | |||
|
|
|||
| @django_db_all | |||
| @control_silo_test | |||
| def test_control_processing(task_runner): | |||
| def test_control_processing(task_runner: Callable[..., Any]) -> None: | |||
There was a problem hiding this comment.
Do we have any type exemptions on these files that we need to clear now that we're explicitly typing things?
There was a problem hiding this comment.
In their new location they get opted into our standard mypy rules which led to additional types being added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate more outbox subsystem logic into sentry.hybridcloud.