Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(billing): Remove extra query on RangeQuerySetWrapper #76066

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dashed
Copy link
Member

@dashed dashed commented Aug 13, 2024

While looking at https://github.com/getsentry/getsentry/pull/14901, RangeQuerySetWrapper will emit one extra unnecessary query when the length of the current results is less than step.

@dashed dashed requested review from a team August 13, 2024 16:32
@dashed dashed self-assigned this Aug 13, 2024
@dashed dashed changed the title chore(billing): Reduce extra query on RangeQuerySetWrapper chore(billing): Remove extra query on RangeQuerySetWrapper Aug 13, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 13, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 4, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 4, 2024
@dashed dashed added WIP and removed Stale labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant