Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-search): support IN for semver release search #76313

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Aug 15, 2024

  • adds support for the IN Operator for semver releases.
  • need to support the NOT IN operator as well, as well as any negation conditions
  • tests added

Fixes #76286

@JoshFerge JoshFerge requested review from a team as code owners August 15, 2024 23:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2024
Copy link

codecov bot commented Aug 16, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
21534 1 21533 205
View the top 1 failed tests by shortest run time
tests.sentry.issues.endpoints.test_organization_group_index.GroupListTest test_semver
Stack Traces | 28.6s run time
#x1B[1m#x1B[.../issues/endpoints/test_organization_group_index.py#x1B[0m:1482: in test_semver
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Invalid format of semantic version. For searching non-semver releases, use \\"release:\\" instead."}'#x1B[0m
#x1B[1m#x1B[31mE   assert 400 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 400 = <Response status_code=400, "application/json">.status_code#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

src/sentry/search/events/filter.py Show resolved Hide resolved
else:
semver_filters = []
for v in version:
_, versions = get_versions(v, operator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure get_versions is necessary for IN. Since in will just be doing exact matches, all the sorting junk that we do isn't really relevant.

@getsantry
Copy link
Contributor

getsantry bot commented Sep 7, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 7, 2024
@JoshFerge JoshFerge requested a review from a team as a code owner September 11, 2024 15:57
JoshFerge added a commit that referenced this pull request Sep 11, 2024
support `in` for for release package for issues search. 

related (but this one is much easier):
#76313
@getsantry
Copy link
Contributor

getsantry bot commented Oct 3, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting multiple releases in the Issues search is failing to load
2 participants