Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(querybuilder): Remove remaining params references #76339

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wmak
Copy link
Member

@wmak wmak commented Aug 16, 2024

  • Updates most remaining spots to use SnubaParams instead of Paramstype
  • Still need to update search.events.fields in a future pr

- Updates most remaining spots to use SnubaParams instead of Paramstype
- Still need to update search.events.fields
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

❌ 264 Tests Failed:

Tests completed Failed Passed Skipped
21646 264 21382 203
View the top 3 failed tests by shortest run time
tests.sentry.snuba.metrics.test_query test_validate_where
Stack Traces | 0.069s run time
#x1B[1m#x1B[.../snuba/metrics/test_query.py#x1B[0m:462: in test_validate_where
    where = parse_conditions(query, [], [])
#x1B[1m#x1B[.../snuba/metrics/query_builder.py#x1B[0m:455: in parse_conditions
    query_builder = ReleaseHealthQueryBuilder(
#x1B[1m#x1B[31mE   TypeError: BaseQueryBuilder.__init__() got an unexpected keyword argument 'params'#x1B[0m
tests.sentry.snuba.metrics.test_query_builder test_parse_conditions[!release:[production,foo]-<lambda>]
Stack Traces | 0.075s run time
#x1B[1m#x1B[.../snuba/metrics/test_query_builder.py#x1B[0m:259: in test_parse_conditions
    parse_conditions(query_string, [], []),
#x1B[1m#x1B[.../snuba/metrics/query_builder.py#x1B[0m:455: in parse_conditions
    query_builder = ReleaseHealthQueryBuilder(
#x1B[1m#x1B[31mE   TypeError: BaseQueryBuilder.__init__() got an unexpected keyword argument 'params'#x1B[0m
tests.sentry.snuba.metrics.test_query_builder test_parse_conditions[transaction:"/bar/:orgId/"-<lambda>]
Stack Traces | 0.075s run time
#x1B[1m#x1B[.../snuba/metrics/test_query_builder.py#x1B[0m:259: in test_parse_conditions
    parse_conditions(query_string, [], []),
#x1B[1m#x1B[.../snuba/metrics/query_builder.py#x1B[0m:455: in parse_conditions
    query_builder = ReleaseHealthQueryBuilder(
#x1B[1m#x1B[31mE   TypeError: BaseQueryBuilder.__init__() got an unexpected keyword argument 'params'#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@getsantry
Copy link
Contributor

getsantry bot commented Sep 18, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant