hw(notifications): In-app notifications #76499
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7853543.
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
This PR has a migration; here is the generated SQL for --
-- Create model NotificationHistory
--
CREATE TABLE "sentry_notificationhistory" ("id" bigint NOT NULL PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY, "date_updated" timestamp with time zone NOT NULL, "date_added" timestamp with time zone NULL, "user_id" bigint NULL, "title" varchar NOT NULL, "description" varchar NOT NULL, "status" varchar NOT NULL, "source" varchar NOT NULL, "content" text NOT NULL, "team_id" bigint NULL);
ALTER TABLE "sentry_notificationhistory" ADD CONSTRAINT "sentry_notificationhistory_team_id_7d5d21c6_fk_sentry_team_id" FOREIGN KEY ("team_id") REFERENCES "sentry_team" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_notificationhistory" VALIDATE CONSTRAINT "sentry_notificationhistory_team_id_7d5d21c6_fk_sentry_team_id";
CREATE INDEX CONCURRENTLY "sentry_notificationhistory_user_id_299fa975" ON "sentry_notificationhistory" ("user_id");
CREATE INDEX CONCURRENTLY "sentry_notificationhistory_team_id_7d5d21c6" ON "sentry_notificationhistory" ("team_id");
--
-- Create constraint user_xor_team_required on model notificationhistory
--
ALTER TABLE "sentry_notificationhistory" ADD CONSTRAINT "user_xor_team_required" CHECK ((("user_id" IS NULL AND "team_id" IS NOT NULL) OR ("user_id" IS NOT NULL AND "team_id" IS NULL))) NOT VALID;
ALTER TABLE "sentry_notificationhistory" VALIDATE CONSTRAINT "user_xor_team_required"; |
❌ 67 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo