-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(integrations): Remove indirect imports from messaging integrations #77094
ref(integrations): Remove indirect imports from messaging integrations #77094
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77094 +/- ##
===========================================
+ Coverage 57.34% 78.21% +20.87%
===========================================
Files 6976 6924 -52
Lines 309315 308015 -1300
Branches 50624 50424 -200
===========================================
+ Hits 177368 240913 +63545
+ Misses 127085 60680 -66405
- Partials 4862 6422 +1560 |
This reverts commit 5117fe8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏽
@@ -18,7 +18,9 @@ | |||
IssueAlertNotificationMessageRepository, | |||
) | |||
from sentry.integrations.slack.message_builder.base.block import BlockSlackMessageBuilder | |||
from sentry.integrations.slack.message_builder.notifications import get_message_builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should audit if we even need this service
#77094) Delete star-imports with "noqa: F401,F403" and update related import statements. Move declarations from `__init__.py` to other files.
PR reverted: b797f51 |
Delete star-imports with "noqa: F401,F403" and update related import statements. Move declarations from
__init__.py
to other files.