prototype(worker-tasks): Create pending task store abstraction #77658
+139
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
reviewed
Sep 17, 2024
This is not meant to target prod, it's for prototyping only. Apologies for the confusion! |
markstory
reviewed
Sep 18, 2024
|
|
||
| @dataclass | ||
| class PendingTask: | ||
| proto_task: PendingTaskProto |
There was a problem hiding this comment.
👍 Decorating with a 'domain object' is a good path to take. Copying all the values out of the protobuf will be expensive in aggregate.
We might want to add methods/properties to this object that proxy to the proto_task and have the proto_task be a private property.
| from dataclasses import dataclass | ||
| from enum import Enum | ||
|
|
||
| from sentry_protos.hackweek_team_no_celery_pls.v1alpha.pending_task_pb2 import ( |
There was a problem hiding this comment.
We'll have to come up with a better name for this 😄
| @@ -224,3 +120,4 @@ def do_upkeep( | |||
|
|
|||
| def shutdown(self): | |||
| self.pool.close() | |||
| self.pool.close() | |||
There was a problem hiding this comment.
This is a mistake, it's fixed now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.